Water & Thermos bottles, buy it for life
Kinto from Japan makes tumblers/ thermos bottles that keep drinks hot or cold longer than almost any others, I have yet to buy one but my friend who camps, travels and is in the cold a lot, swears by them.
They have Japanese functional design, are primarily made 18/8 food-grade stainless steel, parts (such as the silicone seal) are available and they seem to last very long.

Cheap they are not. I mostly own stainless double wall thermos bottles from cheap brands like Ikea or local stuff. They are absolutely fine, but if I lived in a cold climate, i'd certainly give Kinto a look.

Klean Kanteen or cheap copies will last nearly forever. I have no experience with their thermos bottles but I have read good things. I own an original and it is great.
Sometimes you see near exact copies -that cost about a fourth- with the same, dimensions for the lid and same threading etc. They had them at Flying Tiger for a while.

I bought four, with all the heat and sun we get and the cycling we do (they fit in a standard bottle holder) I knew we'd get much use out of them and we certainly have. I do not like drinking from plastic, I can usually taste it and a lot of information has come out recently about every plastic bottle releasing far more micro-plastics and nano-plastics than previously believed.
The Klean Kanteen type bottles will eventually dent, but seem to essentially never break, are easy to clean and fill and the only part that may need replacement after much time is the silicone seal, which is available.
If they ever broke, stainless steel can easily be recycled 100% into just as good an material and object, unlike almost every plastic bottle.
By putting a thick sock around it, the light single-walled non thermos Klean Kanteen style bottles can certainly keep a drink colder or warm for some hours.